When You’re Smiling

1928 Jazz Manouche swing Swing 1 grille

Credits

About this song

When You're Smiling (The Whole World Smiles with You) is an American popular song published in 1928 by Mills Music, with songwriting credits to Mark Fisher, Joe Goodwin and Larry Shay. One of its earliest successful recordings was made by Seger Ellis in 1928, but it was Louis Armstrong's 1929 interpretation that helped establish the song as a lasting jazz standard.

Although no confirmed recording by Django Reinhardt is known, the song has a direct connection to his musical circle. On January 24, 1938, his younger brother Joseph Reinhardt recorded an instrumental version in Paris with Alix Combelle's Hot Four. The session featured Philippe Brun on trumpet, Alix Combelle on tenor saxophone, Joseph Reinhardt on guitar and Louis Vola on double bass. Released on the French Swing label, the recording carries matrix number 0SW 2-1.

The song is built around a warm, memorable melody and an optimistic message about the contagious power of happiness. Its cheerful character, flowing harmonic movement and flexible phrasing make it equally suitable for a relaxed jazz performance or an energetic swing interpretation. The melody leaves plenty of room for expressive improvisation.

In Manouche jazz, When You're Smiling fits naturally into the repertoire of swing standards adapted for acoustic string ensembles. Its harmonic structure provides opportunities for melodic variation, while the driving rhythm of la pompe can give the tune a distinctly Gypsy jazz character. Joseph Reinhardt's 1938 recording offers a particularly interesting historical connection between the American songbook and the Parisian jazz scene surrounding Django Reinhardt.

Interesting facts:

  • Louis Armstrong recorded the song in 1929 and returned to it several times throughout his career, helping transform a popular tune into a jazz classic.
  • Billie Holiday recorded When You're Smiling with Teddy Wilson's orchestra on January 6, 1938, featuring musicians including Lester Young.
  • Frank Sinatra performed the song in the 1952 musical drama Meet Danny Wilson.
  • The song became an unofficial anthem of Leicester City Football Club. Supporters have sung it for decades, and it remains part of the club's matchday tradition.
  • Despite its uplifting reputation during difficult times, the song was published in 1928, before the beginning of the Great Depression.

Nearly a century after its publication, When You're Smiling remains a timeless celebration of joy, swing and musical connection. From Louis Armstrong's recordings to the acoustic jazz tradition of the Reinhardt family, its melody continues to bring musicians and audiences together.

Available grilles

Choose a published chord grille or arrangement, open the interactive Viewer or start Play Along.

CHORD DICTIONARY

Chords in published arrangements

Chords found across the public Grilles published for this Song.

Browse all chords →
15 chord types 40 chord events 1 public Grilles
Show all 15 chords